Skip to content

Use applicationPasswordExperiment local FF as condition for feature toggle visibility #16093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2025
Merged

Use applicationPasswordExperiment local FF as condition for feature toggle visibility #16093

merged 1 commit into from
Sep 8, 2025

Conversation

@RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Sep 5, 2025 •
edited
Loading

WOOMOB-1189

This is a follow UP PR to also include local FF value in release since the Make Application Passwords toggle visible only for WP.com authenticated users didn't make it in code freeze. Only including the local FF value usage according to suggestion.

Screenshots

N/A

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@RafaelKayumov RafaelKayumov added this to the 23.2 ❄️ milestone Sep 5, 2025
@RafaelKayumov RafaelKayumov added the type: task An internally driven task. label Sep 5, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Sep 5, 2025 •
edited
Loading

1 Warning
⚠️ This PR is assigned to the milestone 23.2 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 5, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16093-48f5ff3
Version23.2
Bundle IDcom.automattic.alpha.woocommerce
Commit48f5ff3
Installation URL0ogn586a90ov8
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo self-assigned this Sep 8, 2025
itsmeichigo
itsmeichigo approved these changes Sep 8, 2025
View reviewed changes
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@RafaelKayumov RafaelKayumov merged commit 31df959 into release/23.2 Sep 8, 2025
19 of 21 checks passed
@RafaelKayumov RafaelKayumov deleted the WOOMOB-1189-app-password-toggle-visibility-update branch September 8, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsmeichigo itsmeichigo itsmeichigo approved these changes

Assignees

@itsmeichigo itsmeichigo

Labels

type: task An internally driven task.

Projects

None yet

Milestone

23.2

Development

Successfully merging this pull request may close these issues.

5 participants

@RafaelKayumov @dangermattic @wpmobilebot @itsmeichigo